Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify Vocational XP Tooltip #5949

Merged
merged 1 commit into from
Feb 1, 2025

Conversation

IllianiCBT
Copy link
Collaborator

  • Updated tooltip text for Vocational XP to specify that 'Relief Duty' contracts are excluded from the doubled XP exclusion. Previously the tooltip stated that all contracts ending in 'Duty' were excluded from granting double xp awards.

This was a visual bug only.

Updated tooltip text for vocational XP to specify that 'Relief Duty' contracts are excluded from the doubled XP rule. This clarification ensures better understanding of contract classification and related XP awarding logic.
@IllianiCBT IllianiCBT self-assigned this Feb 1, 2025
Copy link
Collaborator

@Sleet01 Sleet01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Feb 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.27%. Comparing base (4b2b18b) to head (6123146).
Report is 21 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5949      +/-   ##
============================================
- Coverage     10.28%   10.27%   -0.01%     
+ Complexity     6123     6121       -2     
============================================
  Files          1039     1039              
  Lines        139328   139350      +22     
  Branches      20632    20636       +4     
============================================
- Hits          14331    14321      -10     
- Misses       123589   123614      +25     
- Partials       1408     1415       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rjhancock rjhancock merged commit 575bd43 into MegaMek:master Feb 1, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants