Fixed Loading & Saving of Some Campaign Options #5858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the logic for handling AtB and StratCon compatibility, ensuring proper selection behavior. Streamlined disallowing Clan parts usage from IS sources, fixing a duplicate line. Corrected and completed financial year duration configuration in the finances tab.
IllianiCBT
added
Campaign Options
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5858 +/- ##
============================================
- Coverage 10.31% 10.29% -0.02%
+ Complexity 6128 6122 -6
============================================
Files 1038 1038
Lines 138806 139049 +243
Branches 20551 20592 +41
============================================
Hits 14322 14322
- Misses 123094 123328 +234
- Partials 1390 1399 +9 ☔ View full report in Codecov by Sentry. |
Deleted unused `TRANSIT_UNIT_*` constants and associated methods from `CampaignOptions`. Added new options for mercenary size limits and infantry usage in `MarketsTab`, extending campaign options functionality.
Implemented a new panel and controls in the AbilitiesTab to configure the cost per rank of Edge for combat abilities. Updated UI components and resources to support this addition, ensuring a user-friendly interface.
Removed the Edge Cost panel and its related components from the AbilitiesTab. This cleanup eliminates unused elements and simplifies the UI code structure.
Updated `SkillsTab` to accept `CampaignOptions` for enhanced configuration management. Implemented edge cost configuration in the UI and synced it with campaign options for loading and saving. This improves extensibility and maintains consistency across campaign settings.
Implemented functionality to load and apply preset rank systems within the campaign options, ensuring greater customization and consistency. Updated relevant methods and class references to handle the new rank system parameter appropriately.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #5860