Fix Support Point Acquisition Visual Bug #5733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced the use of negotiatedSupportPoints with maxSupportPoints to ensure the correct value is displayed in messages. This change clarifies the information presented and aligns the displayed value with the expected behavior.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5733 +/- ##
============================================
- Coverage 10.19% 10.19% -0.01%
+ Complexity 6067 6066 -1
============================================
Files 1010 1010
Lines 139352 139356 +4
Branches 20447 20450 +3
============================================
- Hits 14212 14207 -5
- Misses 123765 123773 +8
- Partials 1375 1376 +1 ☔ View full report in Codecov by Sentry. |
HammerGS
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
negotiatedSupportPointswithmaxSupportPointsto ensure the correct value is displayed in messages.Fix #5726