Added Handling for Unsupported Unit Types #5720
Merged
+84
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added functionality to automatically sell unsupported units, such as gun emplacements, upon campaign load. Affected units are listed in a notification to the user, and their assigned personnel are unassigned. Updated resource bundle and supporting methods to accommodate this change.
Excluded gun emplacements from salvage as they are unsupported in MekHQ. This ensures consistency and avoids unintended gameplay behavior during scenario resolution.
Prevented the selection of Gun Emplacement units in MekHQ if they are unsupported. Added a user-facing message indicating the restriction and integrated appropriate resource strings for localization. This ensures better handling of unsupported unit types.
Sleet01
approved these changes
Jan 9, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5720 +/- ##
============================================
+ Coverage 10.03% 10.21% +0.17%
- Complexity 6069 6070 +1
============================================
Files 1074 1009 -65
Lines 141525 139242 -2283
Branches 20666 20437 -229
============================================
+ Hits 14209 14221 +12
+ Misses 125944 123651 -2293
+ Partials 1372 1370 -2 ☔ View full report in Codecov by Sentry. |
Scoppio
reviewed
Jan 9, 2025
Comment on lines
+469
to
+481
| if (!soldUnits.isEmpty()) { | ||
| StringBuilder message = new StringBuilder(resources.getString("unsupportedUnits.body")); | ||
|
|
||
| for (Unit soldUnit : soldUnits) { | ||
| retVal.getQuartermaster().sellUnit(soldUnit); | ||
| message.append("- ").append(soldUnit.getName()).append("<br>"); | ||
| } | ||
|
|
||
| JOptionPane.showMessageDialog(null, | ||
| String.format("<html>%s</html>", message), | ||
| resources.getString("unsupportedUnits.title"), | ||
| JOptionPane.WARNING_MESSAGE); | ||
| } |
There was a problem hiding this comment.
this can't be in a static function because it has reference to the resources, which is in the base instance.
There was a problem hiding this comment.
That was fixed a while ago - if you're referring to what I think you are. If you update your master it should be good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unsupported unit types are handled in the following manner: