Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Unit Name Reset #5704

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Fixed Unit Name Reset #5704

merged 1 commit into from
Jan 9, 2025

Conversation

IllianiCBT
Copy link
Collaborator

  • Previously, canceling the unit name prompt reset the unit's name to an empty string. This fix ensures that the unit keeps its original name if the prompt is canceled.

Fix #5612

Previously, canceling the unit name prompt reset the unit's name to an empty string. This fix ensures that the unit keeps its original name if the prompt is canceled.
@IllianiCBT IllianiCBT added Bug UX User experience labels Jan 8, 2025
@IllianiCBT IllianiCBT self-assigned this Jan 8, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.02%. Comparing base (4cf3be1) to head (9161a4d).
Report is 85 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5704      +/-   ##
============================================
- Coverage     10.02%   10.02%   -0.01%     
+ Complexity     6068     6065       -3     
============================================
  Files          1074     1074              
  Lines        141641   141642       +1     
  Branches      20645    20645              
============================================
- Hits          14206    14203       -3     
- Misses       126063   126068       +5     
+ Partials       1372     1371       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Sleet01 Sleet01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Sleet01 Sleet01 merged commit ba6995c into MegaMek:master Jan 9, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug UX User experience
Projects
None yet
3 participants