cleanup: Declaring a method parameter as final for an interface metho… #5658
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -244,7 +244,7 @@ | |||
| * | |||
| * @param campaign the campaign to use in determining the offers to remove | |||
| */ | |||
| protected abstract void removeUnitOffers(final Campaign campaign); | |||
| protected abstract void removeUnitOffers(Campaign campaign); | |||
Check notice
Code scanning / CodeQL
Useless parameter Note
| @@ -294,5 +294,5 @@ | |||
| * @param currentYear The current year | |||
| * @return List of turrets | |||
| */ | |||
| List<MekSummary> generateTurrets(final int num, final SkillLevel skill, final int quality, final int currentYear); | |||
| List<MekSummary> generateTurrets(int num, SkillLevel skill, int quality, int currentYear); | |||
Check notice
Code scanning / CodeQL
Useless parameter Note
| @@ -37,5 +37,5 @@ | |||
| void initPlugin(Campaign c); | |||
|
|
|||
| void loadFieldsFromXml(Node node); | |||
| void writeToXML(final PrintWriter pw, int indent); | |||
| void writeToXML(PrintWriter pw, int indent); | |||
Check notice
Code scanning / CodeQL
Useless parameter Note
| @@ -37,5 +37,5 @@ | |||
| void initPlugin(Campaign c); | |||
|
|
|||
| void loadFieldsFromXml(Node node); | |||
| void writeToXML(final PrintWriter pw, int indent); | |||
| void writeToXML(PrintWriter pw, int indent); | |||
Check notice
Code scanning / CodeQL
Useless parameter Note
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5658 +/- ##
============================================
- Coverage 10.21% 10.20% -0.02%
+ Complexity 6076 6066 -10
============================================
Files 1010 1010
Lines 139310 139310
Branches 20448 20448
============================================
- Hits 14231 14210 -21
- Misses 123703 123731 +28
+ Partials 1376 1369 -7 ☔ View full report in Codecov by Sentry. |
|
Hmm, I might need some help on this one. Should those functions the Github bot marked be public? |
this bot is crazy. But yes, they are supposed to be public, interfaces only allow for protected or private functions in the most modern versions os java (I believe java 18 or 21). |
…d is useless because the implementation may choose to not respect it. https://docs.pmd-code.org/pmd-doc-7.9.0/pmd_rules_java_codestyle.html#finalparameterinabstractmethod
firefly2442
force-pushed
the
pmd-final-cleanup
branch
from
b14d5fc to
930f28f
Compare
|
PMD no longer flags these as issues. Double check me here though, I'm pretty rusty with Java. |
…d is useless because the implementation may choose to not respect it.
https://docs.pmd-code.org/pmd-doc-7.9.0/pmd_rules_java_codestyle.html#finalparameterinabstractmethod