Renamed Strategic Formations to Combat Teams
#5340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced all occurrences of `StrategicFormation` with `CombatTeam`. Updated associated methods, variables, and references across multiple classes to align with this new terminology.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| * current campaign. | ||
| */ | ||
| public Hashtable<Integer, StrategicFormation> getStrategicFormationsTable() { | ||
| public Hashtable<Integer, CombatTeam> getCombatTeamsTable() { |
Check notice
Code scanning / CodeQL
Exposing internal representation Note
| NamedNodeMap attrs = wn.getAttributes(); | ||
| Node classNameNode = attrs.getNamedItem("type"); | ||
| String className = classNameNode.getTextContent(); | ||
| try { | ||
| retVal = (StrategicFormation) Class.forName(className).newInstance(); | ||
| retVal = (CombatTeam) Class.forName(className).newInstance(); |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation Note
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5340 +/- ##
============================================
- Coverage 10.47% 10.46% -0.01%
+ Complexity 6069 6061 -8
============================================
Files 959 959
Lines 135559 135559
Branches 19750 19750
============================================
- Hits 14204 14193 -11
- Misses 119997 120010 +13
+ Partials 1358 1356 -2 ☔ View full report in Codecov by Sentry. |
HammerGS
approved these changes
Dec 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced all occurrences of
StrategicFormationwithCombatTeam. Updated associated methods, variables, and references across multiple classes to align with this new terminology.This terminology was changed based on a suggestion by @HammerGS. We spotted some confusion with the 'Strategic Formation' term among the user base. We logic'd that, as military wargamers, users would be more comfortable with the term 'Combat Team'. Especially as this term closely matches the purpose of Strategic Formations.