Adjusted Support Points Negotiation Logic #5283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjusted the logic for calculating negotiated support points to reflect contract force requirements. Also implemented additional points calculation based on the margin of success in negotiations.
Corrected a logic error where the negotiated support points could exceed the maximum allowable value. Ensured that the negotiated support points are capped at the maximum support points negotiated, preventing any overlap.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5283 +/- ##
============================================
- Coverage 10.47% 10.46% -0.01%
+ Complexity 6049 6043 -6
============================================
Files 959 959
Lines 135202 135205 +3
Branches 19674 19674
============================================
- Hits 14165 14154 -11
- Misses 119686 119697 +11
- Partials 1351 1354 +3 ☔ View full report in Codecov by Sentry. |
HammerGS
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjusted the logic for calculating negotiated support points.
Each month personnel in the Admin/Transport role use their administration skill to generate Support Points. Previously the number of Support Points that could be generated was capped at the number of Sectors assigned to the contract.
This PR changes this so that the maximum number of Support Points that can be generated, per month, is equal to the number of combat forces required by the contract.
Furthermore, for every 4 points a character exceeds their Admin skill check, that character will generate an extra Support Point. This should allow Elite personnel to carry less skilled characters.