Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Typo and Added null check in RetirementDefectionTracker #5242

Merged
merged 1 commit into from
Nov 24, 2024

Conversation

IllianiCBT
Copy link
Collaborator

Corrected the typo in the resource key "recentPromotion" and added a null check for the last promotion date before calculating the months difference. This ensures the application does not encounter a silent null pointer exception.

Closes #5235

Corrected the typo in the resource key "recentPromotion" and added a `null` check for the last promotion date before calculating the months difference. This ensures the application does not encounter a silent null pointer exception.
@IllianiCBT IllianiCBT added Bug Personnel Personnel-related Issues labels Nov 24, 2024
@IllianiCBT IllianiCBT self-assigned this Nov 24, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.50%. Comparing base (bce5f63) to head (580dec2).
Report is 68 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5242      +/-   ##
============================================
- Coverage     10.52%   10.50%   -0.02%     
+ Complexity     6047     6039       -8     
============================================
  Files           957      957              
  Lines        134523   134609      +86     
  Branches      19545    19535      -10     
============================================
- Hits          14154    14147       -7     
- Misses       119018   119106      +88     
- Partials       1351     1356       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@IllianiCBT IllianiCBT merged commit ff3ffec into MegaMek:master Nov 24, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Personnel Personnel-related Issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No message to say that no employees are eligible for turnover
3 participants