Removed Legacy AtB Guaranteed SPAs #5225
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed hard-coded logic for SPA gain when improving personnel from Regular -> Veteran and Veteran -> Elite.
Legacy AtB has personnel automatically gain SPA when reaching Veteran and Elite ratings. Personnel acquired off the market have a random chance of 0-2 SPAs, plus those guaranteed SPAs.
SPAs cost around 50 xp each. Hitting Elite will cost 170-340 xp (depending on whether it's a one or two skill profession). That means buying an Elite character from the personnel market is the equivalent of getting 320-540+ xp for effectively free.
Furthermore, these hardcoded SPA improvements cause problems for anyone wanting to play using CamOps, as they need to manually remove the hardcoded SPAs prior to adding their own picks.
While the second issue could be resolved by adding a campaign option to disable fixed SPAs, I would prefer that we remove hardcoded SPA gains entirely. The benefit of being able to grab an Elite character from the market with 2-4 SPAs already acquired is simply too powerful. Being able to hire Elites is already a no-brainer, they don't need to also arrive with a few hundred xp of SPAs too.
Note: characters can still spawn with 0-2 random SPAs, with higher rated characters more likely to appear with a random SPA. This PR only removes the guaranteed SPAs gained from hitting Veteran and Elite (or spawning at Veteran or Elite).