Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed Legacy AtB Guaranteed SPAs #5225

Merged
merged 1 commit into from
Nov 23, 2024

Conversation

IllianiCBT
Copy link
Collaborator

@IllianiCBT IllianiCBT commented Nov 19, 2024

Removed hard-coded logic for SPA gain when improving personnel from Regular -> Veteran and Veteran -> Elite.

Legacy AtB has personnel automatically gain SPA when reaching Veteran and Elite ratings. Personnel acquired off the market have a random chance of 0-2 SPAs, plus those guaranteed SPAs.

SPAs cost around 50 xp each. Hitting Elite will cost 170-340 xp (depending on whether it's a one or two skill profession). That means buying an Elite character from the personnel market is the equivalent of getting 320-540+ xp for effectively free.

Furthermore, these hardcoded SPA improvements cause problems for anyone wanting to play using CamOps, as they need to manually remove the hardcoded SPAs prior to adding their own picks.

While the second issue could be resolved by adding a campaign option to disable fixed SPAs, I would prefer that we remove hardcoded SPA gains entirely. The benefit of being able to grab an Elite character from the market with 2-4 SPAs already acquired is simply too powerful. Being able to hire Elites is already a no-brainer, they don't need to also arrive with a few hundred xp of SPAs too.

Note: characters can still spawn with 0-2 random SPAs, with higher rated characters more likely to appear with a random SPA. This PR only removes the guaranteed SPAs gained from hitting Veteran and Elite (or spawning at Veteran or Elite).

Removed hard-coded logic for SPA gain when improving personnel from Regular -> Veteran and Veteran -> Elite.
@IllianiCBT IllianiCBT self-assigned this Nov 19, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.51%. Comparing base (bce5f63) to head (7c69d3c).
Report is 42 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5225      +/-   ##
============================================
- Coverage     10.52%   10.51%   -0.01%     
+ Complexity     6047     6040       -7     
============================================
  Files           957      957              
  Lines        134523   134482      -41     
  Branches      19545    19527      -18     
============================================
- Hits          14154    14147       -7     
+ Misses       119018   118985      -33     
+ Partials       1351     1350       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@HammerGS HammerGS merged commit 77704f1 into MegaMek:master Nov 23, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants