Adjusted Command Rights Scenario Modifiers

[IllianiCBT]

Adjusted the command rights modifiers based on player feedback.

Originally the intent was to roll these modifiers back to their 50.0 values, however that presented a couple of issues. As those modifiers use fixed unit counts we end up in a situation where we have to use magic numbers to guesstimate the power of those units when preparing the contract difficulty estimate. It also fails to scale with the player force, leading to an undesirable scenario where the player might have a tiny force (say, a couple of Warrior VTOL) and the allied princess drops two 100t assault 'meks.

Instead, I've opted to keep things scaled by BV, but adjusted the BV multiplier to reduce the overall size of engagements and to reduce the players' reliance on the performance of their allied Princess (the two chief causes of concern).

Independent: No Allies -> no change
Liaison: 1x Heavy or Assault 'Mek -> no change
Integrated: 200% Allies -> 50% Allies
House: 100% Allies -> 25% Allies

This means a 7,500 GBV player force can expect 3,750 GBV of allies on Integrated contracts, or 1,875 of allies on House contracts. This should amount to a couple of extra units, similar to the fixed values found in <50.01. Note that with the current set up it is possible for the allied force to exceed this target value by around 25%. We have a solution in the works, but it's a really big project so will come later.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.51%. Comparing base (bce5f63) to head (63db181).
Report is 38 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #5223      +/-   ##
============================================
- Coverage     10.52%   10.51%   -0.01%     
+ Complexity     6047     6043       -4     
============================================
  Files           957      957              
  Lines        134523   134523              
  Branches      19545    19545              
============================================
- Hits          14154    14149       -5     
  Misses       119018   119018              
- Partials       1351     1356       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

---

🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests

[Setsul]

The ally weights in the contract difficulty estimate will need to be adjusted to match this.

[IllianiCBT]

Ack! I made a mental note about that yesterday and then completely forgot it by this morning. Thanks for the catch. Any recommended values?

[IllianiCBT]

Actually, I know exactly what I'll do

[IllianiCBT]

The scope of this PR has changed. The title & description has been updated accordingly.

[Setsul]

I see what you're going for.
You might still want to set the estimate ratios slightly higher than the guaranteed allied forces', since there are random scenario modifiers that we still want to factor into the difficulty estimate a bit.
Liaison also probably also has to be adjusted downwards a bit, since we don't want that to have more of an effect on the difficulty estimate than House/Integrated.
Though to be honest, Liaison is highly dependent on the player's average number of unit and GBV per lance compared to a single unit within a certain weight range, so it's all guesswork without making that part of the method much more complex.

Figuring out the exact values for the difficult estimate is fairly low priority until the balance of the BV budgets has been settled, so I'd call it good enough for now.

[IllianiCBT]

Liaison is a big thorn in our side, one that I'm not entirely sure how to resolve cheaply.

My current thinking is that the difficulty estimate is 'good enough'. If you want to take another look at the values, though, I definitely wouldn't turn down the help. Especially as you seem to have a better grasp of maths than me :D

[Setsul]

We're actually doing most of the work to do it properly already, it'll just be awkward to get the data since it's done in a different method. We can fairly easily figure out the average BV per player lance. What would need to be added is the logic get the average BV of an allied heavy/assault mek, but that's still easy enough.

I think the end goal should be to overhaul the difficulty estimate and make it factor in vehicles as well, but either way that's beyond the scope here.

Again, I'd call it good enough for now and look into again after scenario modifiers are settled a bit more. For a better estimate I'll also have to look into the chances of random modifiers that add allied forces.

[Setsul]

I think you forgot to adjust the actual ratios and only changed the comments in commit 1d0f4da

[IllianiCBT]

Ugh, no, I'm just clearly one coffee short of a braincell this morning. Fixing