Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BattleArmor customization/refit overweight check. #5187

Merged
merged 1 commit into from
Nov 23, 2024

Conversation

Setsul
Copy link
Contributor

@Setsul Setsul commented Nov 10, 2024

All the prep work was already done, see line 328-331.
Closes #5185
Closes #846

That's got to be some kind of record, 6 years for a one line fix.

@codecov-commenter
Copy link

codecov-commenter commented Nov 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.52%. Comparing base (907de4f) to head (bce5f63).
Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #5187   +/-   ##
=========================================
  Coverage     10.52%   10.52%           
- Complexity     6044     6047    +3     
=========================================
  Files           957      957           
  Lines        134523   134523           
  Branches      19545    19545           
=========================================
+ Hits          14153    14154    +1     
+ Misses       119021   119018    -3     
- Partials       1349     1351    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Collaborator

@Scoppio Scoppio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeap, thats a clear bug right there

@HammerGS HammerGS merged commit b69f6b8 into MegaMek:master Nov 23, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants