Refactored DropShip Salvage Handling #4922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved DropShip Bonus calculation outside of the conditional block for ejected units. This change ensures that the DropShip bonus is consistently applied. Adjusted the existing logic to avoid redundant checks and improve code readability. Refactored `processGame` to remove single or abbreviated variable names.
IllianiCBT
commented
Sep 27, 2024
| } else if (e.getOwner().isEnemyOf(client.getLocalPlayer())) { | ||
| if (e instanceof EjectedCrew) { | ||
| enemyEjections.put(UUID.fromString(e.getCrew().getExternalIdAsString()), (EjectedCrew) e); | ||
| } else if (wreck.getOwner().isEnemyOf(client.getLocalPlayer())) { |
There was a problem hiding this comment.
Non-refactoring changes start here and end on line 374
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4922 +/- ##
=========================================
Coverage 10.45% 10.46%
- Complexity 6008 6015 +7
=========================================
Files 952 951 -1
Lines 132759 132835 +76
Branches 19309 19309
=========================================
+ Hits 13885 13895 +10
- Misses 117518 117589 +71
+ Partials 1356 1351 -5 ☔ View full report in Codecov by Sentry. |
HammerGS
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved DropShip Bonus calculation outside of the conditional block for ejected units. This change ensures that the DropShip bonus is consistently applied. Adjusted the existing logic to avoid redundant checks and improve code readability.
Refactored
processGameto remove single or abbreviated variable names.Closes #4845