Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplified Tech Personnel Checks #4911

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

IllianiCBT
Copy link
Collaborator

Removed experience level checks from tech personnel checks to streamline the determination of technician roles. This removes the really weird situation where ultra-green techs can't be assigned to units (or, in some cases, repair tasks). Whether they should be assigned is something best left to the player. This was particularly odd, as this is the only role that had the 'must be Green or better' restriction.

Removed experience level checks from tech personnel checks to streamline the determination of technician roles. This removes the really weird situation where ultra-green techs can't be assigned to units (or, in some cases, repair tasks). Whether they _should_ be assigned is something best left to the player. This was particularly odd, as this is the only role that had the 'must be Green or better' restriction.
@IllianiCBT IllianiCBT added the Personnel Personnel-related Issues label Sep 26, 2024
@IllianiCBT IllianiCBT self-assigned this Sep 26, 2024
@IllianiCBT
Copy link
Collaborator Author

For the curious, this was why sometimes you'd end up with techs not assigned to units, when using the company generator.

@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.45%. Comparing base (2b9ba00) to head (4103d14).
Report is 25 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #4911   +/-   ##
=========================================
  Coverage     10.45%   10.45%           
+ Complexity     6006     6005    -1     
=========================================
  Files           952      952           
  Lines        132755   132753    -2     
  Branches      19308    19304    -4     
=========================================
  Hits          13882    13882           
+ Misses       117527   117523    -4     
- Partials       1346     1348    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HammerGS HammerGS merged commit 90d45f2 into MegaMek:master Sep 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Personnel Personnel-related Issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants