Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate contract modifiers when adding contracts individually #4906

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

Algebro7
Copy link
Collaborator

The CamOps contract market had a NPE when contracts were GM-added and the modifiers had not previously been populated on a monthly refresh. This PR populates the modifiers if a contract is added and they haven't been initialized.

Closes #4897

@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.46%. Comparing base (2b9ba00) to head (e98a6de).
Report is 13 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #4906   +/-   ##
=========================================
  Coverage     10.45%   10.46%           
- Complexity     6006     6011    +5     
=========================================
  Files           952      952           
  Lines        132755   132759    +4     
  Branches      19308    19308           
=========================================
+ Hits          13882    13889    +7     
  Misses       117527   117527           
+ Partials       1346     1343    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HammerGS HammerGS merged commit 4dd6b3a into MegaMek:master Sep 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants