Added Default Maintenance Time Campaign Setting #4905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduced a default maintenance time option in `CampaignOptions`. Updated relevant classes to use this setting, including `Campaign`, `Unit`, and UI components.
IllianiCBT
added
the
Campaign Options
Updated the tooltip for the 'Default Maintenance Time' label to provide a clearer explanation of its function. This setting now accurately describes its role in modifying maintenance time for new units.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4905 +/- ##
============================================
- Coverage 10.45% 10.45% -0.01%
- Complexity 6006 6008 +2
============================================
Files 952 952
Lines 132755 132783 +28
Branches 19308 19309 +1
============================================
- Hits 13882 13880 -2
- Misses 117527 117550 +23
- Partials 1346 1353 +7 ☔ View full report in Codecov by Sentry. |
HammerGS
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced a default maintenance time option in
CampaignOptions(defaults to x4). Updated relevant classes to use this setting, includingCampaign,Unit, and UI components.Closes #4776