Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added <50.01 Compatibility Handler for Removed Clan Tech Knowledge SPA #4902

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

IllianiCBT
Copy link
Collaborator

Added a check to exclude the "clan_tech_knowledge" key from being written to the XML file. This ensures compatibility with versions before 50.01.

Closes #4901

Added a check to exclude the "clan_tech_knowledge" key from being written to the XML file. This ensures compatibility with versions before 50.01.
@IllianiCBT IllianiCBT added Bug SPA Any issue relating to SPA's. Includes Bugs and RFE Compatibility An issue relating to compatibility between Milestones labels Sep 26, 2024
@IllianiCBT IllianiCBT self-assigned this Sep 26, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.43%. Comparing base (876131a) to head (c74b5ee).
Report is 46 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4902      +/-   ##
============================================
- Coverage     10.45%   10.43%   -0.02%     
+ Complexity     6008     5995      -13     
============================================
  Files           952      952              
  Lines        132755   132759       +4     
  Branches      19308    19309       +1     
============================================
- Hits          13884    13860      -24     
- Misses       117521   117550      +29     
+ Partials       1350     1349       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HammerGS HammerGS merged commit b70357d into MegaMek:master Sep 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Compatibility An issue relating to compatibility between Milestones SPA Any issue relating to SPA's. Includes Bugs and RFE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[0.50.01-SNAPSHOT] Non-Mek Techs Generate NPE When Right-Clicked
3 participants