Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Logger Level from Error to Warn for SPA Loader #4893

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

IllianiCBT
Copy link
Collaborator

Adjusted the logging level from error to warn when restoring an SPA fails. This avoids an error dialog appearing whenever a character with a no-longer existing SPA is loaded. Instead, it will report to the log and advance to the next SPA.

Closes #4890

Adjusted the logging level from error to warn when restoring an SPA fails. This avoids an error dialog appearing whenever a character with a no-longer existing SPA is loaded. Instead, it will report to the log and advance to the next SPA.
@IllianiCBT IllianiCBT added UX User experience SPA Any issue relating to SPA's. Includes Bugs and RFE labels Sep 26, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.45%. Comparing base (caef4d9) to head (876131a).
Report is 17 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4893      +/-   ##
============================================
- Coverage     10.46%   10.45%   -0.01%     
+ Complexity     6017     6008       -9     
============================================
  Files           952      952              
  Lines        132755   132755              
  Branches      19308    19308              
============================================
- Hits          13894    13884      -10     
- Misses       117516   117521       +5     
- Partials       1345     1350       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IllianiCBT IllianiCBT self-assigned this Sep 26, 2024
@IllianiCBT IllianiCBT merged commit f973202 into MegaMek:master Sep 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SPA Any issue relating to SPA's. Includes Bugs and RFE UX User experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[0.50.01 Nightly] Loading existing campaign causes clan_tech_knowledge error.
3 participants