Fixed Birthday Anniversary Events, Added Employment Anniversary Events #4886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed birthday anniversary events to actually declare when a character has a birthday (previously we were incorrectly only checking whether today's date matched the characters literal date of birth, whoops). Renamed `p` to `person` in the `processNewDayPersonnel` method to improve code readability. Added detailed Javadoc comments to explain the daily tasks performed on each active person for better maintenance and understanding.
IllianiCBT
commented
Sep 25, 2024
|
|
||
| // Anniversaries | ||
| if ((p.getRank().isOfficer()) || (!getCampaignOptions().isAnnounceOfficersOnly())) { | ||
| if ((p.getBirthday().isEqual(getLocalDate())) && (campaignOptions.isAnnounceBirthdays())) { | ||
| LocalDate birthday = person.getBirthday(); |
There was a problem hiding this comment.
Non-refactoring changes, in this file, start here
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4886 +/- ##
============================================
- Coverage 10.46% 10.44% -0.02%
+ Complexity 6014 6002 -12
============================================
Files 953 953
Lines 132794 132856 +62
Branches 19318 19329 +11
============================================
- Hits 13898 13878 -20
- Misses 117544 117626 +82
Partials 1352 1352 ☔ View full report in Codecov by Sentry. |
IllianiCBT
changed the title
Introduced recruitment anniversary notifications and related configurations. Updated methods to use `getDateOfBirth` for birthday data extraction to enhance clarity.
IllianiCBT
commented
Sep 25, 2024
| @@ -1352,10 +1338,20 @@ public void setBirthday(final LocalDate birthday) { | |||
| * | |||
| * @return a LocalDate representing the person's date of birth | |||
| */ | |||
| public LocalDate getBirthday() { | |||
| public LocalDate getDateOfBirth() { | |||
There was a problem hiding this comment.
More non-refactoring changes in this class
IllianiCBT
commented
Sep 25, 2024
| @@ -19,17 +19,6 @@ | |||
| */ | |||
There was a problem hiding this comment.
This Class has non-refactoring changes (introduction of a new campaign option)
IllianiCBT
commented
Sep 25, 2024
| @@ -18,43 +18,6 @@ | |||
| */ | |||
There was a problem hiding this comment.
This Class has non-refactoring changes (introduction of a new campaign option)
Updated method names in various files to use `setDateOfBirth` instead of `setBirthday` to enhance clarity and consistency throughout the codebase. This change involved updating method calls and documentation comments accordingly.
# Conflicts: # MekHQ/src/mekhq/campaign/Campaign.java # MekHQ/src/mekhq/campaign/CampaignOptions.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed birthday anniversary events to actually declare when a character has a birthday (previously we were incorrectly only checking whether today's date matched the characters literal date of birth, whoops).
Added an anniversary event that announces how many years it has been since the character was recruited by the campaign.
Renamed
ptopersonin theprocessNewDayPersonnelmethod to improve code readability.Renamed
getBirthday&setBirthdayin thePersonclass togetDateOfBirth/setDateOfBirthto make it clearer that these method concern the day the character was born and not their annual birthday.Added detailed JavaDoc comments to explain the daily tasks performed on each active person for better maintenance and understanding.