Added Ability to Define Skill Levels When Using GM Hire Minimum Complement #4885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expanded the personnel hiring command set to include various skill levels: Elite, Veteran, Regular, Green, and Ultra Green. Modified the menu to allow users to select the desired skill level when hiring the minimum complement of personnel. Updated the overrideSkills method to be usable in different contexts within the campaign.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4885 +/- ##
==========================================
Coverage 10.45% 10.45%
- Complexity 5978 6010 +32
==========================================
Files 953 953
Lines 132333 132714 +381
Branches 19206 19301 +95
==========================================
+ Hits 13833 13881 +48
- Misses 117172 117490 +318
- Partials 1328 1343 +15 ☔ View full report in Codecov by Sentry. |
|
Picked up conflicts |
# Conflicts: # MekHQ/src/mekhq/gui/adapter/UnitTableMouseAdapter.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expanded the personnel hiring command set to include various skill levels: Elite, Veteran, Regular, Green, and Ultra Green. Modified the menu to allow users to select the desired skill level when hiring the minimum complement of personnel. Updated the
overrideSkillsmethod to be usable in different contexts within the campaign.Closes #351 && #4752