Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove untreated personnel nag for prisoner-defectors and add unit tests #4796

Merged

Conversation

Algebro7
Copy link
Collaborator

@Algebro7 Algebro7 commented Sep 6, 2024

This fixes the "untreated personnel" nag by having it exclude defectors. Illiani suggested making sure that bondsmen are also excluded, so I added unit tests to cover that as well as other cases. Note I had to make isUntreatedInjury() "package-private" instead of fully private in order to test it, but I don't think that should have any impact since only classes in the exact same package can access it.

Closes #4789

@Algebro7 Algebro7 changed the title Remove untreated personnel nag for prisoner-defectors and add unit tests Remove untreated personnel nag for prisoners and add unit tests Sep 6, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 11.24%. Comparing base (4fa9b72) to head (f5083a8).
Report is 126 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4796      +/-   ##
============================================
+ Coverage     10.68%   11.24%   +0.56%     
- Complexity     5710     5941     +231     
============================================
  Files           950      950              
  Lines        131302   131306       +4     
  Branches      19135    19139       +4     
============================================
+ Hits          14025    14767     +742     
+ Misses       116052   115224     -828     
- Partials       1225     1315      +90     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Algebro7 Algebro7 changed the title Remove untreated personnel nag for prisoners and add unit tests Remove untreated personnel nag for prisoner-defectors and add unit tests Sep 6, 2024
@Algebro7 Algebro7 force-pushed the fix-untreated-personnel-nag-for-prisoners branch from 4037841 to f5083a8 Compare September 8, 2024 19:05
@IllianiCBT IllianiCBT merged commit 82cc25f into MegaMek:master Sep 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

50.00 - Untreated Personnel Nag is counting untreated Defectors.
3 participants