Remove untreated personnel nag for prisoner-defectors and add unit tests #4796
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the "untreated personnel" nag by having it exclude defectors. Illiani suggested making sure that bondsmen are also excluded, so I added unit tests to cover that as well as other cases. Note I had to make
isUntreatedInjury()
"package-private" instead of fully private in order to test it, but I don't think that should have any impact since only classes in the exact same package can access it.Closes #4789