Second attempt: Sell Parts from Parts in Use Dialog #4792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4792 +/- ##
============================================
- Coverage 10.76% 10.76% -0.01%
+ Complexity 5668 5667 -1
============================================
Files 948 948
Lines 132553 132569 +16
Branches 19048 19052 +4
============================================
- Hits 14272 14269 -3
- Misses 117041 117061 +20
+ Partials 1240 1239 -1 ☔ View full report in Codecov by Sentry. |
IllianiCBT
approved these changes
Sep 5, 2024
There was a problem hiding this comment.
Marking this as approved, despite a minor bit of feedback. Overall the code is clean and looks functional. I would definitely want this in the hands of QA so they can vigorously test it, so once it’s merged please flag it in the QA channel and ask them to break it. With this being such a high demand function, I wanna make sure it hits release in a 10/10 state, if that makes sense.
Algebro7
force-pushed
the
refactor-parts-in-use-dialog
branch
from
80ef8ce to
0dd549a
Compare
|
This has caught some conflicts following the recent name changes. |
# Conflicts: # MekHQ/src/mekhq/campaign/parts/PartInUse.java # MekHQ/src/mekhq/gui/dialog/PartsReportDialog.java
Algebro7
force-pushed
the
refactor-parts-in-use-dialog
branch
from
0dd549a to
51714d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR re-implements selling parts from the parts in use dialog in a (hopefully) much more robust way. Rather than storing strings representing the name and looking up the parts in the warehouse, which was incredibly unreliable due to inconsistent naming under the hood, references to the legit spare part objects are stored in the PartInUse row when building out the table. These objects are rebuilt everytime the table refreshes or is re-opened so there should be no concern about the extra persistent state.
I also added a
getSellableQuantity()method to thePartclass, primarily to be overridden byAmmoStorageandArmor, which track their quantities different than all other parts. This allows the caller to not have to explicitly check the type of the Part being sold.Closes #4723