Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GameManager package/class to new name #4778

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

Algebro7
Copy link
Collaborator

@Algebro7 Algebro7 commented Sep 3, 2024

GameManager in Megamek was refactored into megamek.server.totalwarfare.TWGameManager recently, which caused MekHQ to fail to compile. There were only two instances I found that needed to be updated, and all MekHQ unit tests were still passing.

@codecov-commenter
Copy link

codecov-commenter commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.80%. Comparing base (20ea3a7) to head (3aae92e).
Report is 59 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4778      +/-   ##
============================================
+ Coverage     10.68%   10.80%   +0.12%     
- Complexity     5709     5714       +5     
============================================
  Files           950      950              
  Lines        131268   131306      +38     
  Branches      19136    19139       +3     
============================================
+ Hits          14021    14193     +172     
+ Misses       116022   115886     -136     
- Partials       1225     1227       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@neoancient neoancient merged commit 1348549 into MegaMek:master Sep 3, 2024
3 checks passed
@Algebro7 Algebro7 deleted the tw-game-manager-fix branch September 3, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants