Fixed Skill Level Retrieval Method in AtBDynamicScenario #4703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the method from getLevel() to getTotalSkillLevel() to ensure the correct skill level plus bonus is retrieved for commanders.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4703 +/- ##
============================================
+ Coverage 10.68% 10.80% +0.12%
- Complexity 5709 5715 +6
============================================
Files 950 950
Lines 131268 131267 -1
Branches 19136 19135 -1
============================================
+ Hits 14021 14189 +168
+ Misses 116022 115853 -169
Partials 1225 1225 ☔ View full report in Codecov by Sentry. |
NickAragua
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the skill retrieval method from
getLevel()togetTotalSkillLevel()to ensure skill level plus bonus is retrieved for commanders.This bug affected things like the speed of deployment when the scenario calls for staggered deployment, the number of scenario re-rolls, the number of hidden units during an ambush scenario, reinforcement speed, and the number of leadership units.
Closes #3769