Refactored Salary Editing Logic #4698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a utility function to clamp salary values, ensuring they fall within a specified range.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4698 +/- ##
============================================
- Coverage 10.68% 10.11% -0.57%
+ Complexity 5709 5703 -6
============================================
Files 950 950
Lines 131268 131270 +2
Branches 19136 19136
============================================
- Hits 14021 13273 -748
- Misses 116022 116773 +751
+ Partials 1225 1224 -1 ☔ View full report in Codecov by Sentry. |
Sleet01
approved these changes
Sep 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a utility function to clamp salary values, ensuring they fall within a specified range.
Also increased the maximum salary from 100,000 to 1,000,000,000. This should be more than sufficient for our users.
Closes #4697