Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add current edge total to the tech information #4696

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

azhais
Copy link

@azhais azhais commented Aug 23, 2024

Resolves RFE #4695

Show current edge as long as edge for support personnel is enabled in the options and the specific tech has the repair failure edge trigger enabled.

@codecov-commenter
Copy link

codecov-commenter commented Aug 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.66%. Comparing base (20ea3a7) to head (74e3c47).
Report is 6 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4696      +/-   ##
============================================
- Coverage     10.68%   10.66%   -0.02%     
+ Complexity     5709     5705       -4     
============================================
  Files           950      950              
  Lines        131268   131273       +5     
  Branches      19136    19138       +2     
============================================
- Hits          14021    13997      -24     
- Misses       116022   116051      +29     
  Partials       1225     1225              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IllianiCBT
Copy link
Collaborator

While I was amused to see you make that RFE, I want to be clear that I only asked you to make an RFE because I didn’t realize you were offering to implement this yourself xD

@azhais
Copy link
Author

azhais commented Aug 23, 2024

Oh, I'd have made it either way. Long habit from work that all commits need a ticket.

@IllianiCBT IllianiCBT merged commit d60443f into MegaMek:master Aug 27, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants