Corrected Experience Generation Logic and Refined Campaign Options GUI #4690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed bug in experience level generation that caused rolls of 2 to result in Ultra-Green personnel. Replaced direct value checks with a clamped switch case for experience level generation. Streamlined the campaign options pane by removing unused skill levels and updating labels for clarity.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4690 +/- ##
============================================
+ Coverage 10.79% 10.81% +0.01%
- Complexity 5710 5715 +5
============================================
Files 950 950
Lines 131271 131270 -1
Branches 19135 19133 -2
============================================
+ Hits 14177 14191 +14
+ Misses 115875 115855 -20
- Partials 1219 1224 +5 ☔ View full report in Codecov by Sentry. |
IllianiCBT
changed the title
|
Sorry - just downloaded the nightly to test. Does this make substantive changes or are these cosmetic? Looks like lot of campaign options stuff. If it needs testing I can wait for the artifact build and redownload... |
|
The only non-cosmetic change is that a roll of a 2 on the table to determine starting Experience Level will generate Green personnel, not Ultra-Green to match TW. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed bug in experience level generation that caused rolls of 2 to result in Ultra-Green personnel.
Replaced direct value checks with a clamped switch case for experience level generation.
Streamlined the campaign options pane by removing unused skill levels and updating labels for clarity.