Fixed NPE in AutoAwardsController #4685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the kill filtering logic to handle cases where the mission is null, preventing a possible NPE when accessing mission details.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4685 +/- ##
=========================================
Coverage 10.79% 10.80%
- Complexity 5710 5712 +2
=========================================
Files 950 950
Lines 131271 131275 +4
Branches 19135 19132 -3
=========================================
+ Hits 14177 14188 +11
+ Misses 115875 115864 -11
- Partials 1219 1223 +4 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the kill filtering logic to handle cases where the mission is null, preventing a possible NPE when accessing mission details.
Closes #4683