Update CamOps Personnel Market to Properly Not Generate Personnel on a roll of 7 #4677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4677 +/- ##
============================================
- Coverage 10.79% 10.23% -0.57%
+ Complexity 5710 5708 -2
============================================
Files 950 950
Lines 131271 131277 +6
Branches 19135 19133 -2
============================================
- Hits 14177 13442 -735
- Misses 115875 116610 +735
- Partials 1219 1225 +6 ☔ View full report in Codecov by Sentry. |
IllianiCBT
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A tester in Discord pointed out that the CamOps personnel market was occasionally generating personnel without a role. I observed that this was happening on rolls of 7, which CamOps page 203 says should be "no personnel available". Instead, the market was generating personnel without any roles which is kind of weird. Note this issue predates the renaming to CamOps--it existed in the StratOps personnel market as well.