Clean up factions file #4668
Merged
Clean up factions file #4668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This faction was previously misspelled. It also lacked a starting planet, era modifiers, and the correct tags. All of this has now been corrected.
As of this commit, era modifiers are an 11-item list sourced from the fourth printing of Campaign Operations. The "super" tag is already used to indicate superpowers, but wasn't in the list of recognized tags.
Factions that end due to being absorbed, renamed, or merged into another faction have had successors specified when straightforward. Some typos, missing tags, missing starting planets, and incorrect years have also been fixed.
Saklad5
force-pushed
the
faction-cleanup
branch
from
5d80e12 to
d2a2aad
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4668 +/- ##
============================================
+ Coverage 10.23% 10.65% +0.42%
+ Complexity 5706 5701 -5
============================================
Files 950 950
Lines 131272 131272
Branches 19135 19135
============================================
+ Hits 13434 13987 +553
+ Misses 116614 116063 -551
+ Partials 1224 1222 -2 ☔ View full report in Codecov by Sentry. |
Each faction has been given era modifiers where appropriate. For factions that are not explicitly named in CamOps, a comment has been added indicating which faction's modifiers have been used. Modifiers for eras before a faction exists are always 0, and modifiers for eras after a faction dies are left out. Factions that predate the earliest era with modifiers (that is, factions that die before 2398) have no modifiers.
Saklad5
force-pushed
the
faction-cleanup
branch
from
d2a2aad to
0c46daa
Compare
HammerGS
approved these changes
Aug 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In-line comments have been added clarifying the source of each set of era modifiers, and each faction's modifiers have been painstakingly reviewed to ensure the fourth printing of Campaign Operations is followed.
Faction data up to the ilClan era has also been added, including successors and corrections end years.