Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Grammar in Personality Characteristic Descriptions #4639

Merged
merged 5 commits into from
Aug 16, 2024

Conversation

IllianiCBT
Copy link
Collaborator

Changed the pronoun descriptor to always use 'they' and added support for plural forms in trait descriptions. This ensures consistent use of gender-neutral language throughout the personality descriptions and makes the characteristic descriptions sound more natural, addressing some that previously felt a bit stilted.

I also took the opportunity to refactor the method that builds personality descriptions and changed the label of the 'Personality' section of Person View to read 'About' based on Discord feedback. This allows us to include information that isn't just restricted to personality-related data.

Mary has difficulty grasping more complex or abstract ideas, showing a tendency to rely on simpler explanations or solutions. She expresses genuine feelings and intentions, acting with honesty and authenticity in their interactions with others. She is driven by a strong desire to achieve their goals and reach new heights, consistently striving towards personal or professional growth.

Becomes...

Mary shows difficulty grasping more complex or abstract ideas, showing a tendency to rely on simpler explanations or solutions. They show genuine feelings and intentions, acting with honesty and authenticity in their interactions with others. Mary strives to achieve their goals and reach new heights, consistently striving towards personal or professional growth.

Changed the pronoun descriptor to always return 'they' and added support for plural forms in trait descriptions. This ensures consistent use of gender-neutral language throughout the personality descriptions and is more grammatically correct.
Simplified the process of constructing the personality descriptions by streamlining the logic. Shuffled trait descriptions for variety and used a consistent method to alternate between first name and pronoun references.
Corrected a capitalization mistake in the description for "Sincere".
@IllianiCBT IllianiCBT added Bug Personnel Personnel-related Issues labels Aug 15, 2024
@IllianiCBT IllianiCBT self-assigned this Aug 15, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 9.90%. Comparing base (55a2c0a) to head (b12690d).
Report is 20 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4639      +/-   ##
============================================
- Coverage      9.90%    9.90%   -0.01%     
  Complexity     5676     5676              
============================================
  Files           945      945              
  Lines        129596   129635      +39     
  Branches      19086    19093       +7     
============================================
  Hits          12836    12836              
- Misses       115543   115582      +39     
  Partials       1217     1217              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IllianiCBT
Copy link
Collaborator Author

Moved the personality enums from the global personnel enums folder and placed them in the Random Events package so that they're easier to navigate to.

Consolidated the import paths for personality-related enums by renaming directories and updating package paths in multiple files. This refactoring aims to improve the organization and clarity of the project's structure.
# Conflicts:
#	MekHQ/src/mekhq/campaign/personnel/education/EducationController.java
@IllianiCBT IllianiCBT merged commit d16c4ce into MegaMek:master Aug 16, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Personnel Personnel-related Issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants