Improved Edge Trigger Unmarshalling #4632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added methods to enhance Edge trigger processing, improving the handling of disabled Edge triggers. Replaced LogManager with MMLogger for consistent logging.
IllianiCBT
added
Bug
Personnel
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4632 +/- ##
============================================
- Coverage 9.90% 9.90% -0.01%
Complexity 5676 5676
============================================
Files 945 945
Lines 129596 129618 +22
Branches 19086 19087 +1
============================================
+ Hits 12836 12837 +1
- Misses 115543 115564 +21
Partials 1217 1217 ☔ View full report in Codecov by Sentry. |
Renamed methods and variables related to edge handling to use "trigger" terminology for clarity and consistency. Enhanced method documentation to provide clear descriptions of their functionality and parameters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added methods to enhance Edge trigger processing, improving the handling of disabled Edge triggers.
Replaced LogManager with MMLogger for consistent logging.
Closes #4621