Refactored Infantry Sell Value Calculation to Include Unit Quality Multipliers #4580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ltipliers Revised the method for calculating the sell value of infantry units, incorporating unit quality multipliers.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4580 +/- ##
============================================
- Coverage 10.32% 10.31% -0.01%
Complexity 5818 5818
============================================
Files 936 936
Lines 128888 128898 +10
Branches 18960 18962 +2
============================================
- Hits 13302 13300 -2
- Misses 114310 114322 +12
Partials 1276 1276 ☔ View full report in Codecov by Sentry. |
HammerGS
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revised the method for calculating the sell value of infantry units, incorporating unit quality multipliers. This fixes an oversight in #4572.