Fixed Index Out-of-Bounds Error During eraMods Parsing #4577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjusted the era mod loop to iterate based on the length of the `eraMods` array instead of the `values` array. This change prevents potential index out-of-bounds exceptions and ensures all elements in eraMods are correctly assigned.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4577 +/- ##
============================================
- Coverage 10.32% 10.31% -0.01%
Complexity 5818 5818
============================================
Files 936 936
Lines 128888 128888
Branches 18960 18960
============================================
- Hits 13302 13300 -2
- Misses 114310 114312 +2
Partials 1276 1276 ☔ View full report in Codecov by Sentry. |
Updated the eraMods array initialization to dynamically adjust its size based on the number of elements in the input string. This change prevents potential ArrayIndexOutOfBoundsException errors when the number of eraMods values changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjusted the era mod loop to iterate based on the length of the
eraModsarray instead of thevaluesarray. This change prevents potential index out-of-bounds exceptions and ensures all elements in eraMods are correctly assigned.