Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected Errors in Post-Grad & Doctorate Graduation Handler #4564

Merged

Conversation

IllianiCBT
Copy link
Collaborator

This PR addresses a small bug that caused errors when personnel were graduating from Education Level 0 (Early Education) academies, and when graduating from Post-Graduate and Doctorate academies.

I also fixed the color of the highlight text used when getting a Master's or Doctorate degree. MekHQ no longer thinks they are negative events.

Closes #4544

@IllianiCBT IllianiCBT added Bug Personnel Personnel-related Issues labels Aug 7, 2024
@IllianiCBT IllianiCBT self-assigned this Aug 7, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.32%. Comparing base (b5ff179) to head (dc9f2d7).
Report is 6 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4564      +/-   ##
============================================
- Coverage     10.32%   10.32%   -0.01%     
  Complexity     5816     5816              
============================================
  Files           935      935              
  Lines        128792   128798       +6     
  Branches      18951    18949       -2     
============================================
  Hits          13296    13296              
- Misses       114220   114226       +6     
  Partials       1276     1276              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IllianiCBT IllianiCBT merged commit f0a3b2a into MegaMek:master Aug 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Personnel Personnel-related Issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Education NPE
3 participants