Updated Assertiveness and Removed Toughness Biography Entries #4560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the 'Assertive' personality characteristic to be considered a positive trait. Deleted the RandomBackgrounds.properties file and removed toughness-based biographical entries as these were confusing users.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4560 +/- ##
============================================
- Coverage 10.32% 10.32% -0.01%
+ Complexity 5816 5815 -1
============================================
Files 935 935
Lines 128792 128798 +6
Branches 18951 18950 -1
============================================
- Hits 13296 13294 -2
- Misses 114220 114227 +7
- Partials 1276 1277 +1 ☔ View full report in Codecov by Sentry. |
HammerGS
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the 'Assertive' personality characteristic to be considered a positive trait.
Deleted the
RandomBackgrounds.properties(that is only currently used by random Toughness) file and removed toughness-based biographical entries as these were confusing users.