Added DropShip Bounty Settings #4558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduced a new option to award a percentage bonus for destroyed DropShips in campaigns. This bonus can be configured in the campaign settings and will replace the salvage value for DropShips, representing the difficulty of removing large vessels from the field.
Updated the spinner's maximum value for DropShip bonus percentage from 100 to 20. This change better aligns with the intended game mechanics and balance.
|
most excellent! |
Clarified the tooltip for the DropShip bonus percentage option. The new description specifies that setting the option above 0 removes the ability to salvage DropShips from ground maps and provides a bounty instead.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4558 +/- ##
============================================
- Coverage 10.32% 10.32% -0.01%
- Complexity 5816 5817 +1
============================================
Files 935 935
Lines 128792 128835 +43
Branches 18951 18955 +4
============================================
+ Hits 13296 13299 +3
- Misses 114220 114260 +40
Partials 1276 1276 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires MegaMek/megamek#5862
Introduced a new campaign option to award a percentage bonus for destroyed DropShips. This bonus can be configured in the campaign settings and (if enabled) will replace the salvaging of DropShips killed on ground maps with a set percentage of the unit's sale value.
In universe, this represents the difficulty of salvaging large vessels from the field, the salvage site instead being sold to an interested third party.
This was introduced to offer an alternative to the sudden finance spike experienced when killing DropShips. Or, if the employer is allowed to salvage the unit, the ability to suddenly be able to salvage everything until the end of the contract.
Personally, I find a setting of 5% works best, providing a nice boost to finances without derailing the economic/equipment growth of the campaign.
Closes #3577