Fixed NPE in Mass Enroll Filters #4542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored the filtering logic to improve readability and consistency by using `Objects.equals` for comparison and added a null check with `Objects::nonNull`.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4542 +/- ##
============================================
- Coverage 10.32% 10.32% -0.01%
Complexity 5816 5816
============================================
Files 935 935
Lines 128788 128791 +3
Branches 18949 18949
============================================
Hits 13294 13294
- Misses 114218 114221 +3
Partials 1276 1276 ☔ View full report in Codecov by Sentry. |
NickAragua
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a null check to correctly handle situations where no suitable faction is found.
Closes #4532, #4546