Updated Personnel Report to Better Handle Bondsmen & Prisoners #4479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n as Combat Personnel and to Not Consider Injured Prisoners Support Personnel
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4479 +/- ##
============================================
- Coverage 10.32% 10.32% -0.01%
Complexity 5824 5824
============================================
Files 935 935
Lines 128523 128524 +1
Branches 18889 18890 +1
============================================
Hits 13270 13270
- Misses 113977 113978 +1
Partials 1276 1276 ☔ View full report in Codecov by Sentry. |
NickAragua
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR the personnel report will consider injured bondsmen as combat personnel if they have a combat primary role. Previously it always considered them Support personnel.
Similarly, the personnel report no longer considers injured prisoners as support personnel.
Closes #4386