Removed Loyalty Change Event for Executing Prisoners #4476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The prisoner handling process in the game MekHQ received substantial refactoring for better code structure and function efficiency. The changes include modifying the methods for executing and jettisoning prisoners, as well as the introduction of a new method for processing prisoner resolution commands. The logic for loyalty change in response to such events was removed.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4476 +/- ##
=========================================
Coverage 10.31% 10.31%
Complexity 5819 5819
=========================================
Files 931 932 +1
Lines 128210 128209 -1
Branches 18870 18862 -8
=========================================
Hits 13228 13228
+ Misses 113706 113705 -1
Partials 1276 1276 ☔ View full report in Codecov by Sentry. |
HammerGS
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The prisoner handling process in the game MekHQ received substantial refactoring for better code structure and function efficiency. The changes include modifying the methods for executing and jettisoning prisoners, as well as the introduction of a new method for processing prisoner resolution commands.
The logic for loyalty change in response to such events was removed. This decision was made in response to Discord feedback.