Added Prisoner Ransom & Free Prompts to Mission Completion #4469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A new feature was implemented in the mission completion method. This introduction checks if the campaign option 'Use AtB Prisoner Ransom' is enabled. If active, it calculates and presents a total ransom value for all current prisoners. If the user confirms, the ransom is added to the campaign funds and the prisoners are removed from the roster.
Added a new method in the Campaign class to filter for friendly PoWs. Additionally, updated the GUI properties to include dialog for friendly prisoner ransom confirmation. The mouse adapter has been modified to use the updated dialog for friendly prisoner ransom. The BriefingTab has also been updated to incorporate the new friendly ransom process in the mission completion sequence.
HammerGS
approved these changes
Jul 23, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4469 +/- ##
============================================
- Coverage 10.24% 10.23% -0.01%
Complexity 5809 5809
============================================
Files 925 925
Lines 126456 126523 +67
Branches 18770 18781 +11
============================================
Hits 12953 12953
- Misses 112228 112295 +67
Partials 1275 1275 ☔ View full report in Codecov by Sentry. |
# Conflicts: # MekHQ/resources/mekhq/resources/GUI.properties
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, it was very easy to forget to ransom prisoners of war when resolving a Mission. We added a nag to try and resolve this, but I felt we could do more.
Now, when resolving the Mission the user will be presented with a prompt to perform the following actions:
For the first prompt, the user will be given an alternative prompt if they have insufficient funds to ransom their PoWs.