Reordered Asset Removal and Event Trigger in ManageAssetsDialog #4444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The sequence of actions in the deleteAsset() method of ManageAssetsDialog was rearranged. The AssetRemovedEvent is now triggered before the actual asset removal from the assets list to ensure proper event handling.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4444 +/- ##
=========================================
Coverage 10.24% 10.24%
Complexity 5809 5809
=========================================
Files 924 924
Lines 126439 126439
Branches 18767 18768 +1
=========================================
Hits 12953 12953
Misses 112211 112211
Partials 1275 1275 ☔ View full report in Codecov by Sentry. |
HammerGS
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The asset removal event was being called after the asset had been removed, resulting in an out-of-index error. This PR just re-orders them so that the object still exists at the called index when the event occurs, it is then removed once processing has been completed.
Closes #4437