Null protection when generating forces from fixed scenarios like Base Defense #4436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4429.
The 'fixed' scenarios like Base Defense, which are generated via code rather than using scenario template XMLs, call methods in AtBDynamicScenarioFactory so they do not have the same support for passing roles. For now they pass null for the required roles parameter, which requires a bit of extra handling.
There should be some consideration to consolidating these scenario types to use the same template system as the standard scenarios, both for streamlining and to make it easier to customize them at the user/player level.