Removed Week Duration in Education Properties... Again #4431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The durationWeeks.text property was removed from the Education properties file, and all references to it in Academy.java were also removed. Now the duration and distance for education and travel are only represented in days.
# Conflicts: # MekHQ/src/mekhq/campaign/personnel/education/Academy.java
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4431 +/- ##
=========================================
Coverage 10.24% 10.24%
Complexity 5809 5809
=========================================
Files 924 924
Lines 126432 126428 -4
Branches 18769 18767 -2
=========================================
Hits 12953 12953
+ Misses 112204 112200 -4
Partials 1275 1275 ☔ View full report in Codecov by Sentry. |
|
I went ahead and merged this as it was only duplicating already approved code and its absence was breaking the nightly for some users. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The durationWeeks.text property was removed from the Education properties file, and all references to it in Academy.java were also removed. Now the duration and distance for education and travel are only represented in days.
There appears to have been a code regression that caused this previously removed code to return, prompting NPEs.
Closes #4425