Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored Kill Count and Personnel Filtering Methods #4409

Merged

Conversation

IllianiCBT
Copy link
Collaborator

Updated the getIndividualKills method in KillAwards.java to use stream API for filtering mission kills. Improved the personnel filtering process in AutoAwardsController.java by combining all conditions into a single stream filter and removing the separate method for removing dependents and prisoners.

Closes #4408

Updated the getIndividualKills method in KillAwards.java to use stream API for filtering mission kills. Improved the personnel filtering process in AutoAwardsController.java by combining all conditions into a single stream filter and removing the separate method for removing dependents and prisoners.
@IllianiCBT IllianiCBT added Bug Awards Personnel Personnel-related Issues labels Jul 14, 2024
@IllianiCBT IllianiCBT self-assigned this Jul 14, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.27%. Comparing base (f7bd31c) to head (547e759).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #4409   +/-   ##
=========================================
  Coverage     10.27%   10.27%           
  Complexity     5811     5811           
=========================================
  Files           925      925           
  Lines        126031   126024    -7     
  Branches      18627    18631    +4     
=========================================
  Hits          12945    12945           
+ Misses       111811   111804    -7     
  Partials       1275     1275           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IllianiCBT IllianiCBT merged commit 4fd0e07 into MegaMek:master Jul 14, 2024
3 checks passed
@kernhe
Copy link

kernhe commented Jul 15, 2024

Thanks a lot! Works now as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awards Blocker Bug Personnel Personnel-related Issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Complete Mission will screw up Kill Record
3 participants