Added the Ability to Ransom Friendly PoWs #4398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The prisoner ransom command was corrected in the PersonnelTableMouseAdapter. The command was previously 'CMD_RANSOM', but it has been changed to 'CMD_RANSOM_FRIENDLY'.
|
Long awaited feature! Nice. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4398 +/- ##
============================================
- Coverage 10.27% 10.26% -0.01%
Complexity 5811 5811
============================================
Files 925 925
Lines 126031 126051 +20
Branches 18627 18631 +4
============================================
Hits 12945 12945
- Misses 111811 111831 +20
Partials 1275 1275 ☔ View full report in Codecov by Sentry. |
The code now includes a status change for personnel marked as Missing In Action (MIA) to Prisoner of War (POW). This is implemented within a loop that iterates over the personnel, checking for those with an MIA status and changing it to POW, where necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per title, this PR adds the ability to ransom friendly PoWs. The valuation of PoWs is identical to the valuation of enemy prisoners.
This PR is designed to work alongside #4377 to expand user role-play options.