Added the Automatic Release of the Commander Flag upon Commander Departure or Death, and Loyalty Reset upon Sudden Leadership Change #4393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the event of a person's death, the program now also checks if the deceased was a commander. If they were, the commander flag is released, allowing for a potential new assignment.
IllianiCBT
changed the title
IllianiCBT
changed the title
The code for removing the commander flag when a person's status changes has been modified. Previously, the flag was lifted anytime a person's status changed to isDead. Now, it occurs when the status is changed to 'departed unit', which isn't just limited to death.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4393 +/- ##
============================================
- Coverage 10.27% 10.27% -0.01%
- Complexity 5811 5812 +1
============================================
Files 925 925
Lines 126031 126064 +33
Branches 18627 18635 +8
============================================
+ Hits 12945 12948 +3
- Misses 111811 111841 +30
Partials 1275 1275 ☔ View full report in Codecov by Sentry. |
IllianiCBT
changed the title
A new feature for refreshing loyalty upon major leadership changes was added. This occurs when a commander dies, deserts, or defects. An associated configuration option allows this feature to be toggled on or off according to the needs of the campaign.
HammerGS
approved these changes
Jul 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the event of a person's death or departure from the unit, mhq now checks if the individual was the campaign commander. If they were, the commander flag is released, allowing for a potential new assignment.
A lot of the personnel modules utilize the commander flag, and this helps reduce instances where the campaign does not have a valid commander.
Furthermore, a new feature for refreshing loyalty upon major leadership changes has been added. This occurs when a campaign commander dies, deserts, or defects. A campaign option allows this feature to be toggled according to the needs of the campaign.