Fixed Intersected Conditions in CustomizePersonDialog.java #4201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed unnecessary nested condition on choiceOriginalUnit selection - Set fatigue regardless of unit selection - Fixed setting of person's original unit properties and visibility status
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4201 +/- ##
============================================
- Coverage 10.28% 10.28% -0.01%
- Complexity 5816 5822 +6
============================================
Files 921 922 +1
Lines 125827 126068 +241
Branches 18603 18636 +33
============================================
+ Hits 12944 12963 +19
- Misses 111613 111834 +221
- Partials 1270 1271 +1 ☔ View full report in Codecov by Sentry. |
NickAragua
approved these changes
Jun 13, 2024
HammerGS
added a commit
that referenced
this pull request
Jun 15, 2024
+ Fix #4203: Fixed Monthly Unit Market Incorrectly Filtering Out Vehicles + PR #4205: Fixed bug in Company Generator, add word Dragoon in front of Dragoon rating. + PR #4202: Added Parsing for "campaignStartDate" on Campaign Load + PR #4201: Fixed Intersected Conditions in CustomizePersonDialog.java + PR #4199: Updated PersonnelTableMouseAdapter to Support Enrolling Multiple Personnel + PR #4197: Updated Default Support Personnel Counts in Company Generator + Fix 2405: Added Variable Unit Quality to Salvaged Units
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a situation where a couple of lines got intersected (probably during merge) in our code to customizing personnel (the edit person dialogue). This caused the setting of fatigue and the saving of any other changes to be reliant on the
null == choiceOriginalUnit.getSelectedItem()conditional beingtrue.