Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaced Uses of Font Color 'Red' with New MekHQ Font Color Option Call #4156

Merged
merged 4 commits into from
Jun 8, 2024
Merged

Replaced Uses of Font Color 'Red' with New MekHQ Font Color Option Call #4156

merged 4 commits into from
Jun 8, 2024

Conversation

IllianiCBT
Copy link
Collaborator

@IllianiCBT IllianiCBT commented Jun 6, 2024 •
edited
Loading

Requires: #4153

This PR replaces calls to font color 'red' with the 'negative event' font color assigned via the MekHQ Options added by #4153.

@IllianiCBT IllianiCBT changed the title Replaced Uses of Font Color Replaced Uses of Font Color 'Red' with New MekHQ Font Color Option Call Jun 6, 2024
@IllianiCBT IllianiCBT marked this pull request as draft June 6, 2024 00:34
@IllianiCBT IllianiCBT self-assigned this Jun 6, 2024
@IllianiCBT IllianiCBT added Accessibility Work dealing with improving the accessibility of the application GUI labels Jun 6, 2024
@IllianiCBT IllianiCBT marked this pull request as ready for review June 6, 2024 00:42
@IllianiCBT IllianiCBT mentioned this pull request Jun 6, 2024
Merged
SJuliez
SJuliez reviewed Jun 6, 2024
View reviewed changes
Copy link
Member

@SJuliez SJuliez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if leaving the closing /font and /span was on purpose. If so, I'd not do that. Better to either format in code or in resources, but not mixed.

MekHQ/resources/mekhq/resources/AtBStratCon.properties Outdated Show resolved Hide resolved
MekHQ/resources/mekhq/resources/Finances.properties Outdated Show resolved Hide resolved
MekHQ/resources/mekhq/resources/Finances.properties Outdated Show resolved Hide resolved
@IllianiCBT
Copy link
Collaborator Author

Resolved conflicts and addressed requested revisions

@SJuliez SJuliez merged commit f1da206 into MegaMek:master Jun 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SJuliez SJuliez SJuliez approved these changes

Assignees

@IllianiCBT IllianiCBT

Labels
Accessibility Work dealing with improving the accessibility of the application GUI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IllianiCBT @SJuliez