Added Unit Quality Parameter to addNewUnit Method and Related Tests #4150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SJuliez
reviewed
Jun 5, 2024
|
Requested review actions resolved |
This was referenced Jun 6, 2024
SJuliez
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
int qualityparameter to ouraddNewUnit()method, allowing calls to assign quality ratings to the Unit being added.This is needed for a PR I'm working on (to address #2085 & #2405) and to fix a bug/not fully implemented feature with the AtB Unit Market. Due to the number of files this change touched on, it made sense to push the quality parameter addition separately to make reviewing easier.
The Unit Market is meant to sell Units at varying quality ratings, and is set up to do so, however as
addNewUnit()didn't accept a quality parameter all added Units defaulted to quality rating 3 (D). To be clear: this PR only enables the ability to fully implement that functionality, it does not implement the functionality itself. That will be added in a follow-up PR.